Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all colors are in hsl(a) format #3390

Closed
oleq opened this issue Feb 2, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-theme-lark#126
Closed

Make sure all colors are in hsl(a) format #3390

oleq opened this issue Feb 2, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-theme-lark#126
Assignees
@dkonopka

Comments

@oleq
Copy link
Member

oleq commented Feb 2, 2018

There are some places like the custom theme guide where colors are not standardized. This should apply to the entire project, but especially to Lark.

A follow-up of #645.
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Feb 6, 2018
@oleq
Merge pull request #126 from ckeditor/t/124
33c7e0d 
Other: All colors in the styles should be in the HSLa format. Closes #124.
oleq referenced this issue in ckeditor/ckeditor5-ui Feb 6, 2018
@oleq
Merge pull request #364 from ckeditor/t/ckeditor5-theme-lark/124
ff98211 
Docs: All colors should be in the HSLa format (see ckeditor/ckeditor5-theme-lark#124).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
@dkonopka dkonopka mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkonopka dkonopka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

t/124: Standarized colors to hsl/a format. ckeditor/ckeditor5-theme-lark
2 participants
@oleq @dkonopka