Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual test are not updated to the newest dropdown API. #3391

Closed
jodator opened this issue Feb 8, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#130
Closed

Manual test are not updated to the newest dropdown API. #3391

jodator opened this issue Feb 8, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#130
Assignees
@jodator

Comments

@jodator
Copy link
Contributor

jodator commented Feb 8, 2018

As in title - we forgot to update them in ckeditor/ckeditor5-ui#361.
@jodator jodator self-assigned this Feb 8, 2018
@oleq
Copy link
Member

oleq commented Feb 8, 2018

We need that ASAP since without them it's hard to develop other stuff, like fixes to the theme, inverted theme, etc.

@jodator
Copy link
Contributor Author

jodator commented Feb 8, 2018

@oleq the PR is ready already - only small fixes were needed.

oleq referenced this issue in ckeditor/ckeditor5-theme-lark Feb 9, 2018
@oleq
Merge pull request #130 from ckeditor/t/129
553288a 
Other: Manual tests should be aligned to the newest dropdown API (ckeditor/ckeditor5-ui#356). Minor refactoring in the drop-down ecosystem. Closes #129.
oleq referenced this issue in ckeditor/ckeditor5-ui Feb 9, 2018
@oleq
Internal: A minor refactoring in the dropdown ecosystem (see ckeditor…
052bfb1 
…/ckeditor5-theme-lark#129).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Manual test are not updated to the newest dropdown API. ckeditor/ckeditor5-theme-lark
2 participants
@jodator @oleq