Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should balloons share the same background with toolbars? #3400

Closed
oleq opened this issue Feb 16, 2018 · 2 comments
Closed

Should balloons share the same background with toolbars? #3400

oleq opened this issue Feb 16, 2018 · 2 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale

Comments

@oleq
Copy link
Member

oleq commented Feb 16, 2018

A follow-up of ckeditor/ckeditor5-theme-lark#139 (comment).

Pros:

  • consistent look

Cons

  • reduced contrast between edited text and the UI

Unknowns

  • what would the darker background look like when the balloon is big (more controls, inputs, etc.)?

Demos

screen shot 2018-02-16 at 10 40 10

screen shot 2018-02-16 at 10 40 46
@oleq oleq changed the title Should balloons share the same background as toolbars? Should balloons share the same background with toolbars? Feb 16, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
@Reinmar Reinmar added this to the unknown milestone Nov 4, 2019
@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark labels Nov 4, 2019
@pomek pomek removed this from the unknown milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 3, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark resolution:expired This issue was closed due to lack of feedback. status:discussion status:stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Reinmar @oleq @pomek @Mgsy @CKEditorBot