Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split button does not inherit the font color properly #3401

Closed
oleq opened this issue Feb 20, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#152
Closed

Split button does not inherit the font color properly #3401

oleq opened this issue Feb 20, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#152
Assignees
@dkonopka

Comments

@oleq
Copy link
Member

oleq commented Feb 20, 2018

Change the --ck-color-base-text to see the issue.

image
@dkonopka
Copy link
Contributor

dkonopka commented Feb 21, 2018 •
edited
Loading

It's not only split button issue, it's related to two-colored icons.

See http://localhost:8125/ckeditor5-highlight/tests/manual/highlight-buttons.html and change --ck-color-base-text.

Working on it.

dkonopka referenced this issue in ckeditor/ckeditor5-theme-lark Feb 22, 2018
@dkonopka
Merge pull request #152 from ckeditor/t/148b
fbe7e7d 
Other: Fixed the coloring issue with the multi-color icons. Additionally, moved the visual `.ck-icon` styles from `ckeditor5-ui`. Closes #148.
dkonopka referenced this issue in ckeditor/ckeditor5-ui Feb 22, 2018
@dkonopka
Merge pull request #374 from ckeditor/t/ckeditor5-theme-lark/148
728a691 
Feature: Implemented the `IconView#fillColor` observable which fills child `.ck-icon__fill` paths  with the color (see ckeditor/ckeditor5-theme-lark#148).
dkonopka referenced this issue in ckeditor/ckeditor5-highlight Feb 22, 2018
@dkonopka
Merge pull request #12 from ckeditor/t/ckeditor5-theme-lark/148
b87b797 
Internal: Removed the `.ck-highlight-button` and `.ck-highlight-dropdown` CSS classes. Used the `IconView#fillColor` API to control the colors of the icons (see ckeditor/ckeditor5-theme-lark#148).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
@dkonopka dkonopka mentioned this issue Oct 11, 2019
Closed
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkonopka dkonopka

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@oleq @dkonopka