Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added grunt dev:init task. #37

Closed
wants to merge 3 commits into from
Closed

Added grunt dev:init task. #37

wants to merge 3 commits into from

Conversation

szymonkups
Copy link
Contributor

This push request adds grunt dev:init task. It initializes development workspace for current configuration:

  1. Scans trough package.json file and search for dependencies starting with ckeditor5-.
  2. If dependency has a valid GitHub URL ( starting with ckeditor/), task will clone its GitHub repository and link it into node_modules using npm link. For now new repositories are cloned inside the same directory where CKEditor5 repository is located (one level above the location of gruntfile.js).
  3. If commit-ish suffix is included, task will check out repository using that suffix.

@szymonkups szymonkups mentioned this pull request Nov 4, 2015
9 tasks
@Reinmar
Copy link
Member

Reinmar commented Nov 5, 2015

I made a very quick look at the code and it's generally OK. Before we merge it though, please use some of the ES6 goodies like classes, simpler method definitions in objects, arrow functions, etc.

@Reinmar
Copy link
Member

Reinmar commented Nov 6, 2015

If dependency has a valid GitHub URL ( starting with ckeditor/),

I don't think we should require the URL to start from ckeditor/ because we want to allow all developers to create repositories with their plugins and use them the same way we use the official ones. So the only filter would be that the package name must start wit ckeditor5-.

@szymonkups
Copy link
Contributor Author

I will close this and open new PR with a group of grunt task.

@szymonkups szymonkups closed this Nov 16, 2015
@szymonkups szymonkups deleted the t/36-dev-init branch December 2, 2015 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants