Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor crashes when transforming MarkerDelta that has null as one of its ranges. #4062

Closed
scofalik opened this issue May 10, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#944
Closed

Editor crashes when transforming MarkerDelta that has null as one of its ranges. #4062

scofalik opened this issue May 10, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#944
Assignees
@scofalik
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@scofalik
Copy link
Contributor

Editor crashes when transforming MarkerDelta that has a MarkerOperation with null as one of its ranges.

MarkerOperation may have null values, for example when it creates or removes a marker. This was not taken into consideration when writing transformation in engine/model/delta/basic-transformations~transformMarkerDelta.
@scofalik scofalik self-assigned this May 10, 2017
@scofalik scofalik changed the title Editor crashes when transforming MarkerDelta with null as one of it's ranges. Editor crashes when transforming MarkerDelta that has null as one of its ranges. May 10, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-engine May 11, 2017
@Reinmar
Merge pull request #944 from ckeditor/t/943
d328811 
Fix: `MarkerDelta` transformation should no longer cause editor to crash, if a `MarkerOperation` had `null` as it's `oldRange` or `newRange`. Closes #943.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added module:model type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

MarkerDelta transformation should consider ranges equal to null. ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand