Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the link balloon wider #4752

Closed
Reinmar opened this issue Oct 26, 2016 · 6 comments
Closed

Make the link balloon wider #4752

Reinmar opened this issue Oct 26, 2016 · 6 comments
Labels
package:link resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:discussion

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 26, 2016

Currently you can see only small fragment of the URL. We won't be able to make the balloon so wide to fit a whole long URL, but I found that I wished that the input was ~150%-200% of the current size.

@fredck
Copy link
Contributor

fredck commented Oct 26, 2016

The current design is pleasant and seems to do its job. I feel this change as unnecessary at this stage.

@Reinmar
Copy link
Member Author

Reinmar commented Oct 26, 2016

Did you work with the link panel? You cannot see what you're linking to:

screen shot 2016-10-26 at 17 37 01

This is a simple, quite short, link to MDN I can't see it. The input is so narrow that when I move caret to the end of the link I don't see the beginning so I don't know if I haven't missed something (e.g pasted it twice). Being nearly unable to verify what's in there is really irritating.

@Reinmar
Copy link
Member Author

Reinmar commented Oct 26, 2016

We've got plenty of space on the screen. I don't understand why can't we use more.

@fredck
Copy link
Contributor

fredck commented Oct 26, 2016

What you suggest will not solve the problem anyway, because links can, and usually are, big enough to still not fit (take an average link from medium, for example).

There are other UX concerns that you're not taking in consideration. The distance between the balloon connection to the link, the start of the text field and the save button will change. All this changes the usability of the balloon.

Additionally, it's a matter of UI decision, to make it look good as well. I assume the designer wanted to make it look like that.

Anyway, that's just my opinion. Any way is good for me. I just feel that we have to try to do less.

@oleq
Copy link
Member

oleq commented Dec 7, 2016

I assume the designer wanted to make it look like that.

👍

TBH, I'm also against it. To keep long links visible, we'd need to make the panel twice as big. And even then, we wouldn't fix it for all cases. Usually, you just paste a link there and forget about it. Re–editing link is seldom performed.

What we actually need is an ability to open the link https://github.com/ckeditor/ckeditor5-link/issues/31.

@Reinmar
Copy link
Member Author

Reinmar commented Dec 7, 2016

I guess this is enough of "no" :D. Closing. Thanks.

@Reinmar Reinmar closed this as completed Dec 7, 2016
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added module:ux resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:discussion package:link labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:discussion
Projects
None yet
Development

No branches or pull requests

4 participants