Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image upload should not swallow errors throwed from promise #5138

Closed
szymonkups opened this issue Mar 15, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-image#189
Closed

Image upload should not swallow errors throwed from promise #5138

szymonkups opened this issue Mar 15, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-image#189
Assignees
@szymonkups
Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 15

Comments

@szymonkups
Copy link
Contributor

FileRepository returns Loader instances. Loader's methods read() and upload() return promises which can be rejected when upload error occur or uploading is aborted. Any other errors should not be swallowed but throwed.

https://github.com/ckeditor/ckeditor5-image/blob/master/src/imageupload/imageuploadediting.js#L181-L196

This is especially annoying when writing code that reacts on changes made by model.change() called inside then() methods.
@szymonkups szymonkups self-assigned this Mar 15, 2018
oskarwrobel referenced this issue in ckeditor/ckeditor5-image Mar 16, 2018
@oskarwrobel
Merge pull request #189 from ckeditor/t/186
4357336 
Fix: ImageUploadEditing throws unhandled async errors. Closes #186.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 15 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 15
Development

Successfully merging a pull request may close this issue.

Throwing unhandled errors in ImageUploadEditing. ckeditor/ckeditor5-image
2 participants
@szymonkups @mlewand