Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageStyle content styles can be simplified #5196

Closed
oleq opened this issue Aug 21, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-image#317
Closed

ImageStyle content styles can be simplified #5196

oleq opened this issue Aug 21, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-image#317
Assignees
Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Aug 21, 2019

Look like this :not() selector does nothing:

diff --git a/theme/imagestyle.css b/theme/imagestyle.css
index 7ef1fbe..e74b2e1 100644
--- a/theme/imagestyle.css
+++ b/theme/imagestyle.css
@@ -12,9 +12,7 @@
          & .image-style-align-left,
          & .image-style-align-center,
          & .image-style-align-right {
-                  &:not(.image_resized) {
-                           max-width: 50%;
-                  }
+                  max-width: 50%;
          }

          & .image-style-side {

The ImageResize feature adds own styles that override this max-width when enabled https://github.com/ckeditor/ckeditor5-image/blob/8e14b03f920e577cb9ddebd586c5721302abc578/theme/imageresize.css#L6-L7

@mlewand
Copy link
Contributor

mlewand commented Aug 22, 2019

Good catch, thanks @oleq!

jodator referenced this issue in ckeditor/ckeditor5-image Aug 29, 2019
Internal: Simplified aligned image styles. Closes #315.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:image labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:image type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants