-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark each root editable with ".ck-content" class #5323
Comments
It's more or less about
So maybe get rid of |
I think they have different use cases and can be used together. One is to mark the editable element for the editor UI styles. The other to mark content inside so it can be styled. |
Yes, it makes sense. But OTOH one class cannot live without the other, so we could follow KISS here maybe? |
It certainly can. If all styles for CKEditor content will use |
That's a good point, you know. Let's proceed with both |
.ck-content
class
@oleq, do you think that we could do this in iteration 14? |
I think it's a small change so it's doable. It's more about semantics. OTOH, it does not solve our problems with content styles. Or does it? Anyway, with this change, the widget plugin will add editor-specific styles under |
No. It's about making it simpler for developers to style the content inside the editor.
Yep. |
What would developers do then to have their styles displayed correctly in the frontend? |
These are independent things. Styling the content in the frontend is covered by #773. Here, we discuss how to reliably and easily style the content inside the editor, both – by us and by other developers. |
Other: Added the `.ck-content` CSS class to the `EditableUIView` in order to simplify styling the editor content. Closes #176.
Docs: Updated docs after adding .ck-content class. See ckeditor/ckeditor5-ui#176.
As discussed here ckeditor/ckeditor5-image#74 (comment)
Perhaps a more meaningful class to be used in styles for the content would be better.
WDYT?
The text was updated successfully, but these errors were encountered: