Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Split Button dropdown #5434

Closed
jodator opened this issue Nov 20, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#361
Closed

Implement Split Button dropdown #5434

jodator opened this issue Nov 20, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#361
Assignees
@jodator
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 14

Comments

@jodator
Copy link
Contributor

jodator commented Nov 20, 2017

This UI Component should look like option 2 from dropdown button reasearch:

  1. Toolbar component should have two separate active parts:
    • action button - that should invoke active action
    • arrow button - that should open dropdown panel
  2. The keyboard/mouse actions should act:
    • click on button executes command
    • click on arrow opens dropdown
    • enter on button executes command
    • enter or arrow up/dwon on arrow opens dropdown
  3. It should be extensible and allows to implement different UI panels inside dropdown. But the the first implementation should allow to implement highlight UI. As such it should expose a way to:
    • change active command/icon and represent it's state (active/enabled).
@jodator jodator self-assigned this Nov 20, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-ui Feb 8, 2018
@Reinmar
Merge pull request #361 from ckeditor/t/344
0f26ca8 
Other: Introduced `SplitButtonView` and new dropdown creation helpers (`createDropdown()`, `addListToDropdown()` and `addToolbarToDropdown()`) Closes #344. Closes #356.

BREAKING CHANGE: Removed `DropdownModel` interface – you can use dropdown properties directly now. See #356.
BREAKING CHANGE: Removed `createButtonDropdown()` and `ButtonDropdownView`. See #356.
BREAKING CHANGE: Removed `createListDropdown()` and `ListDropdownView`. See #356.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added type:task This issue reports a chore (non-production change) and other types of "todos". package:ui labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

t/344: Refactoring of the dropdown ecosystem ckeditor/ckeditor5-ui
2 participants
@jodator @mlewand