Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComponentFactory should not normalise item names on add() but on has() and create() #5447

Closed
Reinmar opened this issue Mar 8, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-ui#377
Closed

ComponentFactory should not normalise item names on add() but on has() and create() #5447

Reinmar opened this issue Mar 8, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-ui#377
Assignees
@Reinmar
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 14

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 8, 2018

In the documentation we say that this is the way to retrieve all available component names:

Array.from( editor.ui.componentFactory.names() )

Unfortunately, right now it prints out all names lowercased. This can be a bit confusing, especially that in the docs we also list names of these components and we use the format how they are supposed to be names.
@Reinmar Reinmar self-assigned this Mar 8, 2018
jodator referenced this issue in ckeditor/ckeditor5-ui Mar 9, 2018
@jodator
Merge pull request #377 from ckeditor/t/376
b6b39d7 
Other: ComponentFactory.names() will return original component names (instead of normalized names). Closes #376.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Made ComponentFactory.names() return original componenent name. ckeditor/ckeditor5-ui
2 participants
@Reinmar @mlewand