Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research CSS flex box layout in the UI #642

Closed
oleq opened this issue Oct 26, 2017 · 3 comments
Closed

Research CSS flex box layout in the UI #642

oleq opened this issue Oct 26, 2017 · 3 comments
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Oct 26, 2017

ATM we use the float–based element positioning, which isn't the most convenient way of building the interfaces. Flex would speed up the development, shorten the code and solve some issues that required JS solutions.

The only problem here is IE11 which has some issues with Flex but I'm not certain if they will be a problem to us. This must be checked.

The sooner we go with Flex, the better because ATM we're facing a major CSS refactoring (migration to PostCSS) in a couple of days anyway and the number of UI components isn't that big (yet).

@oleq oleq added candidate:1.0.0 package:ui type:task This issue reports a chore (non-production change) and other types of "todos". labels Oct 26, 2017
@mwadams
Copy link

mwadams commented Nov 3, 2017

Having spent a lot of time on FlexBox with IE11 support, the bugs are not challenging to work around (largely, just have a good "reset" to normalize flexbox defaults, and then remember to always use flex: a b c;)

@Reinmar
Copy link
Member

Reinmar commented Apr 5, 2018

What's the status of this? Didn't we move to flex?

@Reinmar Reinmar added this to the backlog milestone Apr 5, 2018
@oleq
Copy link
Member Author

oleq commented Apr 6, 2018

We use flex across the UI ATM. I consider the topic closed.

@oleq oleq closed this as completed Apr 6, 2018
@Reinmar Reinmar removed this from the backlog milestone Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

3 participants