Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow publishing manual tests as standalone files #7076

Closed
oleq opened this issue Jan 25, 2018 · 3 comments
Closed

Allow publishing manual tests as standalone files #7076

oleq opened this issue Jan 25, 2018 · 3 comments
Labels
package:dev resolution:expired This issue was closed due to lack of feedback. status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@oleq
Copy link
Member

oleq commented Jan 25, 2018

Intro

  1. In Shared UI and UX between CKEditor 5 and Letters #645 we want to share the new theme of the editor with the public. Because the theme is complex and there are multiple aspects to be checked (new theme vs. <any feature>), we'd like to simply publish some manual tests that we use every day and so our users (developers) can browse and play with them.
  2. Because the resource paths are absolute, you can't simply publish generated manual tests and run them.
  3. We predict there will be more situations like this in the future.

How to reproduce

  1. cp -r ~/CK/5/ckeditor5/build/.manual-tests ./manual-tests
  2. Assuming that manual-tests is at the root of the web server, run some test e.g. http://localhost/manual-tests/ckeditor5-theme-lark/tests/manual/theme.html in the browser.

Expected

It works.

Actual

Paths to resources are absolute, e.g. <script src="/ckeditor5-theme-lark/tests/manual/theme.js"></script>

Because of that, an error is thrown by the browser GET http://localhost/ckeditor5-theme-lark/tests/manual/theme.js net::ERR_ABORTED.

Quick fix

Replacing all paths to the .js files with relative ones fixes the problem

find manual-tests -type f | LC_ALL=C xargs sed -i '' 's/src=".*manual\//src="/g'

Bonus

It would also be great if there was an index of manual tests generated in .manual-tests/index.html (or whatever), just like http://localhost:8125/.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-dev May 18, 2020
@mlewand mlewand added this to the backlog milestone May 18, 2020
@mlewand mlewand added status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:dev labels May 18, 2020
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev resolution:expired This issue was closed due to lack of feedback. status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

4 participants