Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The listStyle attribute for listItem should be marked as isFormatting #7894

Closed
pomek opened this issue Aug 21, 2020 · 3 comments
Closed

The listStyle attribute for listItem should be marked as isFormatting #7894

pomek opened this issue Aug 21, 2020 · 3 comments
Labels
package:list package:remove-format resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@pomek
Copy link
Member

pomek commented Aug 21, 2020

📝 Provide a description of the improvement

As for now, the feature removes attributes based on the selection.

In the List style feature, we would like to remove the attribute from all lists that the selection is hooked.

We want to tell the command which elements should be removed. See the comment that describes how the feature works: c7e2355 (#7861).

After resolving the ticket, the commit below should be reverted: b3d5eb0 (#7861)


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@pomek pomek added type:improvement This issue reports a possible enhancement of an existing feature. package:list package:remove-format labels Aug 21, 2020
@pomek pomek added this to the nice-to-have milestone Aug 21, 2020
@pomek
Copy link
Member Author

pomek commented Aug 21, 2020

After extracting util (to the public scope) that was used by the command for finding listItems for updating the listStyle attribute, we could consider introducing support in Remove format plugin that will remove the formatting attributes based on a passed collection of items if specified (instead of based on the selection).

@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 12, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:list package:remove-format resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants