Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons may look blurry on LoDPI screens after theme refactoring #808

Closed
oleq opened this issue Feb 2, 2018 · 6 comments
Closed

Some icons may look blurry on LoDPI screens after theme refactoring #808

oleq opened this issue Feb 2, 2018 · 6 comments
Labels
package:theme-lark package:ui resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Feb 2, 2018

Most of them look crisp enough to me but blockquote and image need refactoring.

capture

A follow-up of #645.

@pjasiun
Copy link

pjasiun commented Feb 5, 2018

For me, lists, bold and italic looks very bad on standard screen. :( When I open standard editor I thought there is a rendering bug.

@Reinmar
Copy link
Member

Reinmar commented Feb 5, 2018

The biggest difference is, surprise surprise, in 1px -> 1.5px horizontal/vertical lines. Those are blurry now. But all rounded shapes look as good/bad as they did.

image image

image image

image image


I wonder what would happen if we increased the line width from 1.5px to eg. 1.75px. Or down to 1.25px. It might look sharper then because it would round better to 1px or 2px. While the average width would still be ~3px on retina. Could you do such tests on one of the icons, Olek? I'm really curious to see this live.

@jodator
Copy link
Contributor

jodator commented Feb 5, 2018

For me all the icons are blurry
selection_022

edit: Chrome @ Linux Mint (Ubuntu).

below Firefox (pretty similar):
selection_023

@oleq
Copy link
Member Author

oleq commented Feb 5, 2018

@jodator That looks pretty bad, I admit. Linux, I guess?

We might research 1.25 or 1.75 but in truth, the only safe solutions are 1px and 2px.

Unfortunately, with current technology, we are unable to deliver different icons based on the density of the screen – we'd have to include 2 icon sets in the JS build to do that.

@Reinmar
Copy link
Member

Reinmar commented Feb 5, 2018

I just went quickly through other editors and they are:

  • either awfully blurry (far worse than what we have)
  • or 2px width (which we checked but none of us liked)

That's the state of the web in 2018. Also, it made me realise that I haven't been noticing this so it may happen that we'll stop noticing the blurriness of the new icons in a short time too :D

@Reinmar
Copy link
Member

Reinmar commented Nov 27, 2018

I think I got used to this and no one ever reported it, so I'm closing this ticket.

@Reinmar Reinmar closed this as completed Nov 27, 2018
@Reinmar Reinmar added resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. and removed status:discussion labels Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:theme-lark package:ui resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants