Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversionAPI to the upcastHighlightToMarker view callback #8389

Closed
jodator opened this issue Nov 2, 2020 · 2 comments
Closed

Add conversionAPI to the upcastHighlightToMarker view callback #8389

jodator opened this issue Nov 2, 2020 · 2 comments
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@jodator
Copy link
Contributor

jodator commented Nov 2, 2020

📝 Provide a description of the improvement

It looks like we've missed some callbacks during the latest API updates (#7334):

https://github.com/ckeditor/ckeditor5/blob/7517a0307c879ddab52c0e1f0114d600be842f35/packages/ckeditor5-restricted-editing/src/restrictededitingmode/converters.js#L146 

Additionally - move this method to the conversion API and review current conversion helpers for markers.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@jodator jodator added type:improvement This issue reports a possible enhancement of an existing feature. package:engine squad:dx labels Nov 2, 2020
@mlewand mlewand added this to the nice-to-have milestone Nov 23, 2020
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:dx labels Sep 9, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 14, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Reinmar @jodator @pomek @mlewand @CKEditorBot