Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin fires seeking event after end event #68

Open
hmps opened this issue Apr 1, 2021 · 0 comments
Open

Plugin fires seeking event after end event #68

hmps opened this issue Apr 1, 2021 · 0 comments

Comments

@hmps
Copy link

hmps commented Apr 1, 2021

👋

First off, thank you for your work on this! It looks to be exactly what we need for a simple video editor project. 🙏

We have a particular situation where we show an overlay on the video once it ended. If the user starts scrubbing after this, we remove the overlay to give them access to the video again. We noticed that this line:

this.currentTime(this._offsetEnd - this._offsetStart);

makes the player emit a seeking event after the end event on

this.trigger('ended');

We couldn't figure out the need for this.currentTime(this._offsetEnd - this._offsetStart) (we removed it locally and didn't see any bad effects). Can you tell us what it's needed for?

Would you be willing to change the behavior? Either be removing this.currentTime(this._offsetEnd - this._offsetStart) or by making it configurable.

I'm happy to submit a PR either way, just want to know if it's a direction your willing to take before committing the time 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant