Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control Plane deployment replicas should be a pointer #366

Closed
prometherion opened this issue Aug 31, 2023 · 0 comments · Fixed by #367
Closed

Control Plane deployment replicas should be a pointer #366

prometherion opened this issue Aug 31, 2023 · 0 comments · Fixed by #367
Assignees
@prometherion
Labels
bug Something isn't working
Milestone
v0.3.4

Comments

@prometherion
Copy link
Member

If third-party interactions, such as the Cluster API Control Plane provider, try to scale down to zero the Control Plane are going to get always the default value of two due to the ,omitempty struct tag.

kamaji/api/v1alpha1/tenantcontrolplane_types.go

Lines 110 to 111 in bac5d56

// +kubebuilder:default=2
Replicas int32 `json:"replicas,omitempty"`

How to reproduce

  1. Create the CAPI cluster
  2. Scale the KamajiControlPlane from 2 to a single replica
  3. The TCP is scaled to 1, correctly
  4. Scale the KamajiControlPlane to zero
  5. The TCP is scaled back to 2, the default value
@prometherion prometherion added the bug Something isn't working label Aug 31, 2023
@prometherion prometherion added this to the v0.3.4 milestone Aug 31, 2023
@prometherion prometherion self-assigned this Aug 31, 2023
@prometherion prometherion mentioned this issue Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prometherion prometherion

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3.4
Development

Successfully merging a pull request may close this issue.

fix: tcp deployment replica to pointer prometherion/kamaji
1 participant
@prometherion