Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls does not correctly measure coverage of examples/*. #513

Open
ketch opened this issue May 8, 2015 · 3 comments
Open

Coveralls does not correctly measure coverage of examples/*. #513

ketch opened this issue May 8, 2015 · 3 comments

Comments

@ketch
Copy link
Member

ketch commented May 8, 2015

This seems to be caused by our use of symlinking for the examples directory. When I run the tests locally, the initial coverage report correctly gets the examples. But if I generate an html report (with coverage html) then the examples directory is omitted completely.

Coveralls is including the examples directory but reporting as if we didn't run any of it. This causes overall coverage to be drastically underreported.

One option would be to just move the examples directory down into pyclaw/src/pyclaw/. Or to move everything else up into clawpack/pyclaw.

@mandli
Copy link
Member

mandli commented May 9, 2015

Sorry, I was on my mobile all yesterday. I am just trying to understand what you mean by your options above, namely what context would are you suggesting moving the examples directory. I have not really dealt much with cover-alls so that might be part of the problem.

@ketch
Copy link
Member Author

ketch commented May 10, 2015

I am suggesting revising the directory structure so that coveralls can correctly detect our test coverage. I think that less tricky symlinking would be beneficial anyway.

@mandli
Copy link
Member

mandli commented May 10, 2015

So for in-place installations we would create a symlink down into the package or just get rid of the top-level directory all-together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants