Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plugins (similar to amphora-html) #15

Open
elgreg opened this issue Dec 11, 2019 · 0 comments
Open

Support plugins (similar to amphora-html) #15

elgreg opened this issue Dec 11, 2019 · 0 comments

Comments

@elgreg
Copy link

elgreg commented Dec 11, 2019

It would be great if amphora-amp supported plugins in the same way that amphora-html does. Plugins export a render function that takes ref, data, locals and allows them to filter or move refs within the tree before they are rendered. Our use case would be for those components where we would want them in the head of the page, but amp only supports them in the body (namely, analytics components that we want to run before ads).

This was already implemented for amphora-html and would ideally be a similar PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant