Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

componentVariation support #21

Open
reubenson opened this issue Oct 20, 2020 · 0 comments
Open

componentVariation support #21

reubenson opened this issue Oct 20, 2020 · 0 comments

Comments

@reubenson
Copy link
Contributor

reubenson commented Oct 20, 2020 •
edited
Loading

in amphora-html, componentVariation defaults to the component name if that property is not defined on the component instance. this logic is missing in amphora-amp, which can lead to un-intended consequences when developers are not aware of this discrepancy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reubenson