Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for adding headers to a response in an amphora plugin #57

Open
jonwinton opened this issue Jan 28, 2019 · 0 comments
Open

Allow for adding headers to a response in an amphora plugin #57

jonwinton opened this issue Jan 28, 2019 · 0 comments

Comments

@jonwinton
Copy link
Contributor

@elgreg commented on Tue Oct 17 2017

I'd like to be able to attach a list of all the _refs that are on a page (e.g. the article refs for each story card in the home page) as surrogate keys with fastly. @jonwinton suggested adding the ability to add plugins to rendering in amphora. I'd like to hook into the rendering of the homepage in amphora and add surrogate keys for all URLS of linked articles with a Surrogate-Key: header on the HTTP response


@TTaitFoster commented on Mon Jan 28 2019

Why not just an express middleware?


@elgreg commented on Mon Jan 28 2019

I would prefer that I had access to the components themselves. So maybe this belongs in the renderer?


@jonwinton commented on Mon Jan 28 2019

Yes, completely agree. We'll move to amphora-html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant