Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiln mobile scrolling issues #1037

Closed
nelsonpecora opened this issue Dec 1, 2017 · 5 comments
Closed

Kiln mobile scrolling issues #1037

nelsonpecora opened this issue Dec 1, 2017 · 5 comments
Assignees

Comments

@nelsonpecora
Copy link
Contributor

On mobile, scrolling is very difficult because the component-list dragdrop functionality is triggered. We should improve this so the mobile experience is good.

@nelsonpecora
Copy link
Contributor Author

We should discuss this before updating the dragdrop code

@pfeytser pfeytser modified the milestones: 2017 CW 50-51: end of year cleanup, 2018 CW 1-2: ??? Dec 12, 2017
@nelsonpecora nelsonpecora removed this from the 2018 CW 1-2: ??? milestone Jan 2, 2018
@pfeytser
Copy link

pfeytser commented Jan 2, 2018

Investigate if sortable.js can do tap and hold drag-drop.

@pfeytser pfeytser added this to the 2018 CW 1-2: ??? milestone Jan 2, 2018
@nelsonpecora
Copy link
Contributor Author

It doesn't really do that automatically, unfortunately

@nelsonpecora
Copy link
Contributor Author

There are a few workarounds and open pull requests to add a grab delay to dragula, but it doesn't look like it's being actively maintained. We should probably switch libraries rather than trying to hack it in ourselves.

@nelsonpecora nelsonpecora self-assigned this Jan 12, 2018
@nelsonpecora
Copy link
Contributor Author

Investigation is complete. We should switch to sortable.js, and use a 100ms delay (rather than a pixel deadzone) to solve both the clicking-into-things issue and the mobile scrolling issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants