Skip to content

Commit

Permalink
fix(clerk-js): Add missing localization keys in unstable_errors
Browse files Browse the repository at this point in the history
* fix(clerk-js): Change wording in success password message

* fix(clerk-js): Add missing localization keys in unstable_errors

fix(clerk-js): Add changeset

* Update gorgeous-moose-yawn.md

---------

Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
  • Loading branch information
raptisj and nikosdouvlis authored Jun 19, 2023
1 parent 21adf20 commit 17cc14e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .changeset/gorgeous-moose-yawn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@clerk/localizations': minor
'@clerk/types': minor
---

Add localization keys for when the phone number exists and the last identification is deleted
4 changes: 3 additions & 1 deletion packages/localizations/src/en-US.ts
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,8 @@ export const enUS: LocalizationResource = {
},
},
unstable__errors: {
identification_deletion_failed: 'You cannot delete your last identification.',
phone_number_exists: 'This phone number is taken. Please try another.',
form_identifier_not_found: '',
captcha_invalid:
'Sign up unsuccessful due to failed security validations. Please refresh the page to try again or reach out to support for more assistance.',
Expand Down Expand Up @@ -614,7 +616,7 @@ export const enUS: LocalizationResource = {
zxcvbn: {
notEnough: 'Your password is not strong enough.',
couldBeStronger: 'Your password works, but could be stronger. Try adding more characters.',
goodPassword: 'Nice work. This is an excellent password.',
goodPassword: 'Your password meets all the necessary requirements.',
warnings: {
straightRow: 'Straight rows of keys on your keyboard are easy to guess.',
keyPattern: 'Short keyboard patterns are easy to guess.',
Expand Down
2 changes: 2 additions & 0 deletions packages/types/src/localization.ts
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,8 @@ type _LocalizationResource = {
type WithParamName<T> = T &
Partial<Record<`${keyof T & string}__${CamelToSnake<Exclude<FieldId, 'role'>>}`, LocalizationValue>>;
type UnstableErrors = WithParamName<{
identification_deletion_failed: LocalizationValue;
phone_number_exists: LocalizationValue;
form_identifier_not_found: LocalizationValue;
captcha_invalid: LocalizationValue;
form_password_pwned: LocalizationValue;
Expand Down

0 comments on commit 17cc14e

Please sign in to comment.