fix(nextjs): Append DevBrowser on cross-origin redirects #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a1cb2ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anagstef
changed the title
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
dimkl
approved these changes
Jun 8, 2023
Dev Browser on redirects will only be appended if: - redirectToSignIn or redirectToSignUp have been called, - the Secret Key hints a development Clerk instance, - the redirection is cross-origin
anagstef
added a commit
that referenced
this pull request
Jun 8, 2023
anagstef
force-pushed
the
stefanos/js-447-scope-the-dev-browser-jwt-addition-to-redirecttosignin
branch
from
64a2bcd
to
2d772dc
Compare
anagstef
added a commit
that referenced
this pull request
Jun 8, 2023
anagstef
force-pushed
the
stefanos/js-447-scope-the-dev-browser-jwt-addition-to-redirecttosignin
branch
from
2d772dc
to
16b4f87
Compare
anagstef
force-pushed
the
stefanos/js-447-scope-the-dev-browser-jwt-addition-to-redirecttosignin
branch
from
16b4f87
to
a1cb2ab
Compare
nikosdouvlis
approved these changes
Jun 8, 2023
nikosdouvlis
deleted the
stefanos/js-447-scope-the-dev-browser-jwt-addition-to-redirecttosignin
branch
Closed
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.This PR refactors and improves #1241.
This PR also introduces a new header
x-clerk-redirect-towhich indicates thatredirectToSignInorredirectToSignUphave been called.After this PR, Dev Browser on redirects will only be appended if all of the following conditions apply:
redirectToSignInorredirectToSignUphave been called,This change fixes the dev browser issue on implementations that use custom domains for sign-in or sign-up pages, other than Clerk Hosted Pages.