feat(clerk-js,clerk-react,types): Add unsafeMetadata prop to <SignUp /> #1464
Conversation
🦋 Changeset detectedLatest commit: 2141595 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
| @@ -77,7 +77,9 @@ type ButtonProps = { | |||
| }; | |||
|
|
|||
| export type SignInButtonProps = ButtonProps; | |||
| export type SignUpButtonProps = ButtonProps; | |||
| export interface SignUpButtonProps extends ButtonProps { | |||
There was a problem hiding this comment.
❓Any specific reason we want to switch to an interface and not go with something like this ?
export type SignUpButtonProps = ButtonProps & {unsafeMetadata?: SignUpUnsafeMetadata;}There was a problem hiding this comment.
@panteliselef While not exactly this situation, I tend to refer to this: https://github.com/microsoft/TypeScript/wiki/Performance#preferring-interfaces-over-intersections
That said, happy to use an intersection.
There was a problem hiding this comment.
that's a great read, thanks tom
There was a problem hiding this comment.
@tmilewski Nice one!
Were you able to confirm that the metadata get copied on the newly created user on successful sign up? Does it work with our various sign up methods (password, passwordless and oauth)?
Let me know if you need any help with tests.
@gkats Thanks! Password and passwordless are good to go. Looking through OAuth now. |
|
@gkats Password, Passwordless, OAuth, and Metamask/Web3 all appear to be working as intended. |
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Adds unsafeMetadata prop to the
<SignUp />component to improve flexibility.Fixes USR-99