USR-194 fix(clerk-js): Eliminate pre/post onBlur states for password field #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raptisj
requested review from
SokratisVidros,
nikosdouvlis,
anagstef,
panteliselef and
desiprisg
🦋 Changeset detectedLatest commit: 1f8a125 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
raptisj
force-pushed
the
eliminate_onblur_states
branch
2 times, most recently
from
d17d67b
to
78d2c28
Compare
nikosdouvlis
approved these changes
Jul 28, 2023
raptisj
force-pushed
the
eliminate_onblur_states
branch
from
78d2c28
to
1f7023d
Compare
fix(clerk-js): Eliminate pre/post onBlur states for password field fix(clerk-js): Minor refactor fix(clerk-js): Formating issue
raptisj
force-pushed
the
eliminate_onblur_states
branch
from
1f7023d
to
1f8a125
Compare
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(clerk-js): Eliminate pre/post onBlur states for password field
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Eliminate pre/post onBlur states for password field and prioritize minimum character count error message over other complexity errors.
Before
Screen.Recording.2023-07-27.at.5.09.12.PM.mov
After
Screen.Recording.2023-07-27.at.4.17.18.PM.mov
Screen.Recording.2023-07-27.at.4.28.35.PM.mov