Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types,clerk-js): Introduce OrganizationSuggestion resource and types #1574

Merged

Conversation

chanioxaris
Copy link
Member

@chanioxaris chanioxaris commented Aug 10, 2023

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

We introduce a new OrganizationSuggestion resource and the corresponding types, in order to preview user with suggestions of organizations they can join. The available methods for the time being are retrieve() which return a list of organization suggestions of the user and accept() which allows a user to request to join the organization

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: bca876e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chanioxaris chanioxaris force-pushed the haris/org-105-introduce-organizationsuggestion-resource branch from 24e6f33 to b1f23af Compare August 10, 2023 13:51
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯, added some comments asking for clarifications

packages/types/src/json.ts Outdated Show resolved Hide resolved
packages/types/src/organizationSuggestion.ts Show resolved Hide resolved
@chanioxaris chanioxaris force-pushed the haris/org-105-introduce-organizationsuggestion-resource branch from b1f23af to 940e28e Compare August 10, 2023 15:14
packages/shared/src/hooks/useOrganizationList.tsx Outdated Show resolved Hide resolved
packages/shared/src/hooks/useOrganizationList.tsx Outdated Show resolved Hide resolved
…ypes

We introduce a new OrganizationSuggestion resource and the corresponding
types, in order to preview user with suggestions of organizations they
can join. The available methods for the time being are retrieve() which
return a list of organization suggestions of the user and accept() which
allows a user to request to join the organization.
Also make available the user's suggestions from the useOrganizationList hook
@chanioxaris chanioxaris force-pushed the haris/org-105-introduce-organizationsuggestion-resource branch from 940e28e to e3c0241 Compare August 10, 2023 19:11
@chanioxaris chanioxaris merged commit a412a50 into main Aug 11, 2023
8 checks passed
@chanioxaris chanioxaris deleted the haris/org-105-introduce-organizationsuggestion-resource branch August 11, 2023 07:01
@clerk-cookie clerk-cookie mentioned this pull request Aug 11, 2023
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants