Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localizations): Update Korean Translation: Added Missing Account Deletion Description #1609

Merged
merged 7 commits into from
Aug 22, 2023

Conversation

JungHoonGhae
Copy link
Contributor

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: Translation Update

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

In the English translation(en-US.ts), the description 'Delete your account and all its associated data' was present. However, this was missing in the Korean translation(ko-KR.ts).

This update ensures that the Korean translation also includes the information about deleting all data associated with the account.

This change is essential to provide a clearer understanding to users about the consequences of deleting their account.

In the English translation(en-US.ts), the description 'Delete your account and all its associated data' was present. However, this was missing in the Korean translation(ko-KR.ts). 

This update ensures that the Korean translation also includes the information about deleting all data associated with the account.

This change is essential to provide a clearer understanding to users about the consequences of deleting their account.
Update ko-KR.ts (Added Missing Account Deletion Description)
korean userProfile > dangerSection > deleteAccountDescription update
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

🦋 Changeset detected

Latest commit: a1fdcfa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jit-ci
Copy link

jit-ci bot commented Aug 17, 2023

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🙏

@nikosdouvlis nikosdouvlis merged commit 17b3de9 into clerk:main Aug 22, 2023
8 checks passed
@clerk-cookie clerk-cookie mentioned this pull request Aug 22, 2023
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants