feat(clerk-js): Use Gate in OrganizationSettings #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 41e7308 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
force-pushed
the
ORG-249-settings
branch
from
c23b7e6
to
e7daa5a
Compare
chanioxaris
reviewed
Oct 10, 2023
| @@ -131,10 +133,11 @@ const OrganizationDangerSection = () => { | |||
| colorScheme='danger' | |||
| textVariant='buttonExtraSmallBold' | |||
| onClick={() => navigate('leave')} | |||
| isDisabled={isAdmin && !hasMoreThanOneAdmin} | |||
| // TODO: rewrite to check if user has all clerk permissions and there are more than 1 admins | |||
| isDisabled={!!canDeleteOrganization && !hasMoreThanOneAdmin} | |||
There was a problem hiding this comment.
We can drop the hasMoreThanOneAdmin check and rely on the BE in order to allow or block this action. It's good enough for now to keep it disabled if setting is not enabled or the user doesn't have the proper permission
There was a problem hiding this comment.
Correct, this is a leftover, will update it asap
nikosdouvlis
approved these changes
Oct 10, 2023
panteliselef
force-pushed
the
ORG-249-settings
branch
2 times, most recently
from
7746694
to
9b424bc
Compare
panteliselef
force-pushed
the
ORG-249-settings
branch
from
9b424bc
to
41e7308
Compare
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the role based check with permission based checks inside the OrganizationSettings component
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore