Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js,types,shared): Deprecate __unstable methods for organizations #1879

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

panteliselef
Copy link
Member

Description

This PR continues with the deprecation of the underlying mechanism for organizations.

For context those values were passed around in order to trigger automatic revalidations when devs where reading invitationList or membershipList from useOrganization. Those have been deprecated in favour of invitations and memberships and we are introducing mutations for those here.

Automatic revalidations of lists after calling clerk-js methods may return in the future as an "opt-in" mechanism

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@panteliselef panteliselef requested a review from a team as a code owner October 13, 2023 16:04
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: 84d2143

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@clerk/clerk-js Patch
@clerk/shared Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/clerk-js/src/core/clerk.ts Show resolved Hide resolved
.changeset/light-coats-brush.md Outdated Show resolved Hide resolved
.changeset/light-coats-brush.md Outdated Show resolved Hide resolved
@nikosdouvlis nikosdouvlis merged commit a9894b4 into main Oct 16, 2023
3 of 4 checks passed
@nikosdouvlis nikosdouvlis deleted the ORG-273 branch October 16, 2023 08:29
@clerk-cookie clerk-cookie mentioned this pull request Oct 16, 2023
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants