Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript type definitions #20

Closed
DanielRuf opened this issue Jun 11, 2018 · 7 comments
Closed

Add TypeScript type definitions #20

DanielRuf opened this issue Jun 11, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@DanielRuf
Copy link
Contributor

https://github.com/DefinitelyTyped/DefinitelyTyped

@Turbo87
Copy link
Contributor

Turbo87 commented Jun 11, 2018

Yeah, I think that would be useful, although I'm tempted to just port the project to use TypeScript directly instead... 🤔

@Turbo87 Turbo87 added the enhancement New feature or request label Jun 11, 2018
@Turbo87 Turbo87 changed the title typings for cli-table3 Add TypeScript type definitions Jun 11, 2018
@DanielRuf
Copy link
Contributor Author

Unfortunaltey this does not seem to work with some tools like tslint which looks for @types/cli-table3. So we have to create this to satisfy the tools.

@Turbo87
Copy link
Contributor

Turbo87 commented Jul 19, 2018

@DanielRuf I'm very surprised by that. This is the official and documented way to provide type declarations for TypeScript. Do you have a reproduction somewhere where this does not work and creates problems?

@DanielRuf
Copy link
Contributor Author

@Turbo87 yes, try npm i with ashblue/uvpm-cli#10

@Turbo87
Copy link
Contributor

Turbo87 commented Jul 19, 2018

@DanielRuf 0.5.0 does not include the type definitions yet. apparently I forgot to release it 🤦‍♂️

@Turbo87
Copy link
Contributor

Turbo87 commented Jul 19, 2018

@DanielRuf I've published v0.5.1 including the typedefs, so this should work fine now

@DanielRuf
Copy link
Contributor Author

Awesome, many thanks =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants