From 2aa1f446a960539072d45442fe5740059b8b6931 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Joly?= Date: Sun, 10 Dec 2023 02:42:31 +0000 Subject: [PATCH] test: add test to preserve API compatibility --- rusqlite_migration/src/tests/asynch.rs | 14 ++++ rusqlite_migration/src/tests/helpers.rs | 54 +++++++++++++++ ...ynch__convert_connection_closed_error.snap | 5 ++ ...tests__asynch__convert_rusqlite_error.snap | 8 +++ ...ration__tests__synch__error_display-2.snap | 5 -- ...ration__tests__synch__error_display-3.snap | 5 -- ...ration__tests__synch__error_display-5.snap | 5 -- ...igration__tests__synch__error_display.snap | 5 -- ...nch__error_display__connection_closed.snap | 5 ++ ...ests__synch__error_display__file_load.snap | 5 ++ ...nch__error_display__foreign_key_check.snap | 5 ++ ...on__tests__synch__error_display__hook.snap | 5 ++ ..._error_display__migration_definition.snap} | 2 +- ..._synch__error_display__rusqlite_error.snap | 5 ++ ...ror_display__specified_schema_version.snap | 5 ++ ...s__synch__error_display__unrecognized.snap | 5 ++ ..._tests__synch__error_display_number_0.snap | 5 ++ ..._tests__synch__error_display_number_1.snap | 5 ++ ..._tests__synch__error_display_number_2.snap | 5 ++ ..._tests__synch__error_display_number_3.snap | 5 ++ ..._tests__synch__error_display_number_4.snap | 5 ++ ..._tests__synch__error_display_number_5.snap | 5 ++ ..._tests__synch__error_display_number_6.snap | 5 ++ ..._tests__synch__error_display_number_7.snap | 5 ++ ...__tests__synch__error_source_number_0.snap | 7 ++ ...__tests__synch__error_source_number_1.snap | 10 +++ ...__tests__synch__error_source_number_2.snap | 7 ++ ...__tests__synch__error_source_number_3.snap | 12 ++++ ...__tests__synch__error_source_number_4.snap | 5 ++ ...__tests__synch__error_source_number_5.snap | 5 ++ ...__tests__synch__error_source_number_6.snap | 9 +++ ...__tests__synch__error_source_number_7.snap | 5 ++ ...error_source_number_connection_closed.snap | 5 ++ ..._synch__error_source_number_file_load.snap | 5 ++ ...error_source_number_foreign_key_check.snap | 12 ++++ ...ests__synch__error_source_number_hook.snap | 5 ++ ...or_source_number_migration_definition.snap | 7 ++ ...h__error_source_number_rusqlite_error.snap | 7 ++ ...ource_number_specified_schema_version.snap | 10 +++ ...nch__error_source_number_unrecognized.snap | 9 +++ ..._tests__synch__read_only_db_all_valid.snap | 18 +++++ ...ion__tests__synch__user_version_error.snap | 18 +++++ rusqlite_migration/src/tests/synch.rs | 67 ++++++++++--------- 43 files changed, 348 insertions(+), 53 deletions(-) create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_connection_closed_error.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_rusqlite_error.snap delete mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-2.snap delete mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-3.snap delete mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-5.snap delete mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__connection_closed.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__file_load.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__foreign_key_check.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__hook.snap rename rusqlite_migration/src/tests/snapshots/{rusqlite_migration__tests__synch__error_display-4.snap => rusqlite_migration__tests__synch__error_display__migration_definition.snap} (57%) create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__rusqlite_error.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__specified_schema_version.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__unrecognized.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_0.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_1.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_2.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_3.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_4.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_5.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_6.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_7.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_0.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_1.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_2.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_3.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_4.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_5.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_6.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_7.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_connection_closed.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_file_load.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_foreign_key_check.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_hook.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_migration_definition.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_rusqlite_error.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_specified_schema_version.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_unrecognized.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__read_only_db_all_valid.snap create mode 100644 rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__user_version_error.snap diff --git a/rusqlite_migration/src/tests/asynch.rs b/rusqlite_migration/src/tests/asynch.rs index 48e29cf..9ba9e65 100644 --- a/rusqlite_migration/src/tests/asynch.rs +++ b/rusqlite_migration/src/tests/asynch.rs @@ -118,3 +118,17 @@ async fn test_from_iter() { let migrations = AsyncMigrations::from_iter(vec![m_valid0(), m_valid10()]); assert_eq!(Ok(()), migrations.validate().await); } + +#[tokio::test] +async fn test_tokio_rusqlite_conversion() { + use tokio_rusqlite::Error as TError; + + insta::assert_debug_snapshot!( + "convert_connection_closed_error", + crate::Error::from(TError::ConnectionClosed) + ); + insta::assert_debug_snapshot!( + "convert_rusqlite_error", + crate::Error::from(TError::Rusqlite(rusqlite::Error::InvalidQuery)) + ); +} diff --git a/rusqlite_migration/src/tests/helpers.rs b/rusqlite_migration/src/tests/helpers.rs index bfb69e5..96e52cc 100644 --- a/rusqlite_migration/src/tests/helpers.rs +++ b/rusqlite_migration/src/tests/helpers.rs @@ -80,3 +80,57 @@ pub fn m_invalid_fk() -> M<'static> { ) .foreign_key_check() } + +pub fn all_errors() -> Vec<(&'static str, crate::Error)> { + use crate::Error::*; + use crate::ForeignKeyCheckError; + use crate::MigrationDefinitionError; + use crate::SchemaVersion; + use crate::SchemaVersionError; + + vec![ + ( + "rusqlite_error", + RusqliteError { + query: "SELECT * FROM table42;".to_owned(), + err: rusqlite::Error::InvalidQuery, + }, + ), + ( + "specified_schema_version", + SpecifiedSchemaVersion(SchemaVersionError::TargetVersionOutOfRange { + specified: SchemaVersion::NoneSet, + highest: SchemaVersion::NoneSet, + }), + ), + ( + "migration_definition", + MigrationDefinition(MigrationDefinitionError::NoMigrationsDefined), + ), + ( + "foreign_key_check", + ForeignKeyCheck(vec![ + ForeignKeyCheckError { + table: "t1".to_owned(), + rowid: 1, + parent: "t2".to_owned(), + fkid: 2, + }, + ForeignKeyCheckError { + table: "t3".to_owned(), + rowid: 2, + parent: "t4".to_owned(), + fkid: 3, + }, + ]), + ), + ("hook", Hook("in hook".to_owned())), + ("file_load", FileLoad("file causing problem".to_owned())), + ( + "unrecognized", + Unrecognized(Box::new(Hook("unknown".to_owned()))), + ), + #[cfg(feature = "async-tokio-rusqlite")] + ("connection_closed", ConnectionClosed), + ] +} diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_connection_closed_error.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_connection_closed_error.snap new file mode 100644 index 0000000..05bc838 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_connection_closed_error.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/asynch.rs +expression: "crate::Error::from(TError::ConnectionClosed)" +--- +ConnectionClosed diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_rusqlite_error.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_rusqlite_error.snap new file mode 100644 index 0000000..0ce4f00 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__asynch__convert_rusqlite_error.snap @@ -0,0 +1,8 @@ +--- +source: rusqlite_migration/src/tests/asynch.rs +expression: "crate::Error::from(TError::Rusqlite(rusqlite::Error::InvalidQuery))" +--- +RusqliteError { + query: "", + err: InvalidQuery, +} diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-2.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-2.snap deleted file mode 100644 index 9cfca22..0000000 --- a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-2.snap +++ /dev/null @@ -1,5 +0,0 @@ ---- -source: rusqlite_migration/src/tests/synch.rs -expression: "Error::Hook(String::new())" ---- -rusqlite_migrate error: Hook("") diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-3.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-3.snap deleted file mode 100644 index b919092..0000000 --- a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-3.snap +++ /dev/null @@ -1,5 +0,0 @@ ---- -source: rusqlite_migration/src/tests/synch.rs -expression: "Error::ForeignKeyCheck(vec![ForeignKeyCheckError\n {\n table : String :: new(), rowid : 1, parent : String :: new(), fkid\n : 2,\n }, ForeignKeyCheckError\n {\n table : String :: new(), rowid : 2, parent : String :: new(), fkid\n : 3,\n },])" ---- -rusqlite_migrate error: ForeignKeyCheck([ForeignKeyCheckError { table: "", rowid: 1, parent: "", fkid: 2 }, ForeignKeyCheckError { table: "", rowid: 2, parent: "", fkid: 3 }]) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-5.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-5.snap deleted file mode 100644 index 37797d3..0000000 --- a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-5.snap +++ /dev/null @@ -1,5 +0,0 @@ ---- -source: rusqlite_migration/src/tests/synch.rs -expression: "Error::RusqliteError {\n query: String::new(),\n err: rusqlite::Error::InvalidQuery,\n}" ---- -rusqlite_migrate error: RusqliteError { query: "", err: InvalidQuery } diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display.snap deleted file mode 100644 index ca50b0e..0000000 --- a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display.snap +++ /dev/null @@ -1,5 +0,0 @@ ---- -source: rusqlite_migration/src/tests/synch.rs -expression: "Error::SpecifiedSchemaVersion(SchemaVersionError::TargetVersionOutOfRange {\n specified: SchemaVersion::NoneSet,\n highest: SchemaVersion::NoneSet,\n })" ---- -rusqlite_migrate error: SpecifiedSchemaVersion(TargetVersionOutOfRange { specified: NoneSet, highest: NoneSet }) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__connection_closed.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__connection_closed.snap new file mode 100644 index 0000000..89163b7 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__connection_closed.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: ConnectionClosed diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__file_load.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__file_load.snap new file mode 100644 index 0000000..f29f2d1 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__file_load.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: FileLoad("file causing problem") diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__foreign_key_check.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__foreign_key_check.snap new file mode 100644 index 0000000..a18714a --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__foreign_key_check.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: ForeignKeyCheck([ForeignKeyCheckError { table: "t1", rowid: 1, parent: "t2", fkid: 2 }, ForeignKeyCheckError { table: "t3", rowid: 2, parent: "t4", fkid: 3 }]) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__hook.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__hook.snap new file mode 100644 index 0000000..644a807 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__hook.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: Hook("in hook") diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-4.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__migration_definition.snap similarity index 57% rename from rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-4.snap rename to rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__migration_definition.snap index ab2a2bd..f6d0b68 100644 --- a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display-4.snap +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__migration_definition.snap @@ -1,5 +1,5 @@ --- source: rusqlite_migration/src/tests/synch.rs -expression: "Error::MigrationDefinition(MigrationDefinitionError::NoMigrationsDefined)" +expression: e --- rusqlite_migrate error: MigrationDefinition(NoMigrationsDefined) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__rusqlite_error.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__rusqlite_error.snap new file mode 100644 index 0000000..ee1fdf3 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__rusqlite_error.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: RusqliteError { query: "SELECT * FROM table42;", err: InvalidQuery } diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__specified_schema_version.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__specified_schema_version.snap new file mode 100644 index 0000000..a9cf7b8 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__specified_schema_version.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: SpecifiedSchemaVersion(TargetVersionOutOfRange { specified: NoneSet, highest: NoneSet }) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__unrecognized.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__unrecognized.snap new file mode 100644 index 0000000..904fdd9 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display__unrecognized.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: Unrecognized(Hook("unknown")) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_0.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_0.snap new file mode 100644 index 0000000..ee1fdf3 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_0.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: RusqliteError { query: "SELECT * FROM table42;", err: InvalidQuery } diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_1.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_1.snap new file mode 100644 index 0000000..a9cf7b8 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_1.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: SpecifiedSchemaVersion(TargetVersionOutOfRange { specified: NoneSet, highest: NoneSet }) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_2.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_2.snap new file mode 100644 index 0000000..f6d0b68 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_2.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: MigrationDefinition(NoMigrationsDefined) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_3.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_3.snap new file mode 100644 index 0000000..a18714a --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_3.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: ForeignKeyCheck([ForeignKeyCheckError { table: "t1", rowid: 1, parent: "t2", fkid: 2 }, ForeignKeyCheckError { table: "t3", rowid: 2, parent: "t4", fkid: 3 }]) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_4.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_4.snap new file mode 100644 index 0000000..644a807 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_4.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: Hook("in hook") diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_5.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_5.snap new file mode 100644 index 0000000..f29f2d1 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_5.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: FileLoad("file causing problem") diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_6.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_6.snap new file mode 100644 index 0000000..904fdd9 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_6.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: Unrecognized(Hook("unknown")) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_7.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_7.snap new file mode 100644 index 0000000..89163b7 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_display_number_7.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +rusqlite_migrate error: ConnectionClosed diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_0.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_0.snap new file mode 100644 index 0000000..5b3de81 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_0.snap @@ -0,0 +1,7 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + InvalidQuery, +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_1.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_1.snap new file mode 100644 index 0000000..604f4d6 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_1.snap @@ -0,0 +1,10 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + TargetVersionOutOfRange { + specified: NoneSet, + highest: NoneSet, + }, +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_2.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_2.snap new file mode 100644 index 0000000..a88cde0 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_2.snap @@ -0,0 +1,7 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + NoMigrationsDefined, +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_3.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_3.snap new file mode 100644 index 0000000..0242f9b --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_3.snap @@ -0,0 +1,12 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + ForeignKeyCheckError { + table: "t1", + rowid: 1, + parent: "t2", + fkid: 2, + }, +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_4.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_4.snap new file mode 100644 index 0000000..8128d3b --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_4.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +None diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_5.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_5.snap new file mode 100644 index 0000000..8128d3b --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_5.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +None diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_6.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_6.snap new file mode 100644 index 0000000..a0a931d --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_6.snap @@ -0,0 +1,9 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + Hook( + "unknown", + ), +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_7.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_7.snap new file mode 100644 index 0000000..8128d3b --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_7.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +None diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_connection_closed.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_connection_closed.snap new file mode 100644 index 0000000..8128d3b --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_connection_closed.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +None diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_file_load.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_file_load.snap new file mode 100644 index 0000000..8128d3b --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_file_load.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +None diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_foreign_key_check.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_foreign_key_check.snap new file mode 100644 index 0000000..0242f9b --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_foreign_key_check.snap @@ -0,0 +1,12 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + ForeignKeyCheckError { + table: "t1", + rowid: 1, + parent: "t2", + fkid: 2, + }, +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_hook.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_hook.snap new file mode 100644 index 0000000..8128d3b --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_hook.snap @@ -0,0 +1,5 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +None diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_migration_definition.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_migration_definition.snap new file mode 100644 index 0000000..a88cde0 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_migration_definition.snap @@ -0,0 +1,7 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + NoMigrationsDefined, +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_rusqlite_error.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_rusqlite_error.snap new file mode 100644 index 0000000..5b3de81 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_rusqlite_error.snap @@ -0,0 +1,7 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + InvalidQuery, +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_specified_schema_version.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_specified_schema_version.snap new file mode 100644 index 0000000..604f4d6 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_specified_schema_version.snap @@ -0,0 +1,10 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + TargetVersionOutOfRange { + specified: NoneSet, + highest: NoneSet, + }, +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_unrecognized.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_unrecognized.snap new file mode 100644 index 0000000..a0a931d --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__error_source_number_unrecognized.snap @@ -0,0 +1,9 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e.source() +--- +Some( + Hook( + "unknown", + ), +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__read_only_db_all_valid.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__read_only_db_all_valid.snap new file mode 100644 index 0000000..d5fa168 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__read_only_db_all_valid.snap @@ -0,0 +1,18 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +Err( + RusqliteError { + query: "CREATE TABLE m1(a, b); CREATE TABLE m2(a, b, c);", + err: SqliteFailure( + Error { + code: ReadOnly, + extended_code: 8, + }, + Some( + "attempt to write a readonly database", + ), + ), + }, +) diff --git a/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__user_version_error.snap b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__user_version_error.snap new file mode 100644 index 0000000..fde10e8 --- /dev/null +++ b/rusqlite_migration/src/tests/snapshots/rusqlite_migration__tests__synch__user_version_error.snap @@ -0,0 +1,18 @@ +--- +source: rusqlite_migration/src/tests/synch.rs +expression: e +--- +Err( + RusqliteError { + query: "PRAGMA user_version = 1; -- Approximate query", + err: SqliteFailure( + Error { + code: ReadOnly, + extended_code: 8, + }, + Some( + "attempt to write a readonly database", + ), + ), + }, +) diff --git a/rusqlite_migration/src/tests/synch.rs b/rusqlite_migration/src/tests/synch.rs index efbb8b2..d7d485f 100644 --- a/rusqlite_migration/src/tests/synch.rs +++ b/rusqlite_migration/src/tests/synch.rs @@ -1,6 +1,6 @@ use std::{iter::FromIterator, num::NonZeroUsize}; -use rusqlite::{Connection, Transaction}; +use rusqlite::{Connection, OpenFlags, Transaction}; use crate::{ tests::helpers::{ @@ -10,7 +10,7 @@ use crate::{ SchemaVersionError, M, }; -use super::helpers::{m_invalid0, m_invalid1, m_valid20, m_valid21}; +use super::helpers::{all_errors, m_invalid0, m_invalid1, m_valid20, m_valid21}; #[test] fn empty_migrations_test() { @@ -148,38 +148,19 @@ fn test_migration_definition_error_display() { #[test] fn test_error_display() { - insta::assert_display_snapshot!(Error::SpecifiedSchemaVersion( - SchemaVersionError::TargetVersionOutOfRange { - specified: SchemaVersion::NoneSet, - highest: SchemaVersion::NoneSet, - } - )); - - insta::assert_display_snapshot!(Error::Hook(String::new())); - - insta::assert_display_snapshot!(Error::ForeignKeyCheck(vec![ - ForeignKeyCheckError { - table: String::new(), - rowid: 1, - parent: String::new(), - fkid: 2, - }, - ForeignKeyCheckError { - table: String::new(), - rowid: 2, - parent: String::new(), - fkid: 3, - }, - ])); + for (name, e) in all_errors() { + insta::assert_display_snapshot!(format!("error_display__{name}"), e); + } +} - insta::assert_display_snapshot!(Error::MigrationDefinition( - MigrationDefinitionError::NoMigrationsDefined - )); +#[test] +fn test_error_source() { + use std::error::Error; - insta::assert_display_snapshot!(Error::RusqliteError { - query: String::new(), - err: rusqlite::Error::InvalidQuery, - }); + for (name, e) in all_errors() { + // For API stability reasons (if that changes, we must change the major version) + insta::assert_debug_snapshot!(format!("error_source_number_{name}"), e.source()); + } } #[test] @@ -371,6 +352,18 @@ fn all_valid_test() { insta::assert_debug_snapshot!(migrations) } +// When the DB encounters an error, it is surfaced +#[test] +fn test_read_only_db_all_valid() { + let mut conn = Connection::open_in_memory_with_flags(OpenFlags::SQLITE_OPEN_READ_ONLY).unwrap(); + let migrations = Migrations::new(all_valid()); + + let e = migrations.to_latest(&mut conn); + + assert!(e.is_err()); + insta::assert_debug_snapshot!(e) +} + // If we encounter a database with a migration number higher than the number of defined migration, // we should return an error, not panic. // See https://github.com/cljoly/rusqlite_migration/issues/17 @@ -527,3 +520,13 @@ fn test_from_iter() { let migrations = Migrations::from_iter(vec![m_valid0(), m_valid10()]); assert_eq!(Ok(()), migrations.validate()); } + +#[test] +fn test_user_version_error() { + // This will cause error because the DB is read only + let conn = Connection::open_in_memory_with_flags(OpenFlags::SQLITE_OPEN_READ_ONLY).unwrap(); + let e = crate::set_user_version(&conn, 1); + + assert!(e.is_err(), "{:?}", e); + insta::assert_debug_snapshot!(e) +}