-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
middleware.refresh
/ Haystack can get stuck printing
#870
Comments
@alexander-yakushev just in case - does the stacktrace ring a bell? The fix seems easy anyway but I only started getting these after locally installing cider-nrepl master, so perhaps there's some problem that slipped by. |
The stacktrace only contains |
No, that would not help, because it will only prevent the stringwriter to grow indefinitely, but the pprint endless loop will keep going because it is not cooperating. Is it required to use |
Thanks for the eyeing! Any of the solutions you've recently used/introduced would sound good to me. IMO for Haystack stuff, we should quite agressively trim stuff beyond 1 screenful of text. Any more that that, I'd encourage users to inspect the exception. |
Can you help me understand where that output was going to go? Was it to be printed to the REPL output, or shown as a separate buffer? In any case, IIUC, that So, a simple (but not 100% bulletproof) solution would be to Overall, by skimming through that namespace, I'd say I'm not fond of how liberally it prints through user data that can potentially be big/infinite. Or, maybe, it believes that |
In any case, I believe that all of CIDER (and possibly nrepl) deserves going through all places where something unknown is printed, and making those places more rigorous and robust to arbitrary data. |
Most times it goes to the
Maybe that would be a good and standard-looking approach - ditch
Sounds reasonable. Out of caution, if you'd be interested in improving that area, please as a first pass simply identify the bad areas in a GH issue - perhaps some case deserves a different treatment. |
Is this still on your radar these days? |
Currently doing other things around nREPL, so you can take it. |
My cider-nrepl got stuck on a
refresh
op. A thread keeps working indefinitely.This is the stracktrace grabbed from yourkit https://gist.github.com/vemv/73bd4908dcfe4ea8983d7abb57af9f29
Looks like we could bind some
*print-,,,
options somewhere.The text was updated successfully, but these errors were encountered: