Fix ns detection for complex metadata #555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See clojure-emacs/cider#2821
Use clojure-forward-logical-sexp to reliably skip metadata instead of error-prone regex.
The previous variable
clojure-namespace-name-regex
is kept as obsolete in case it breaks other packages - can remove it directly if that's preferred.One of the commented out
TODO
tests used a old metadata syntax#^{:bar true}
which wasn't supported byclojure--looking-at-non-logical-sexp
Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdoc
and fixed any warnings in the code you've written.