Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protorpc rewrites all 40x errors to 400 #138

Open
inklesspen opened this issue Feb 21, 2018 · 3 comments
Open

protorpc rewrites all 40x errors to 400 #138

inklesspen opened this issue Feb 21, 2018 · 3 comments

Comments

@inklesspen
Copy link
Contributor

Raising an exception such as endpoints.api_exceptions.NotFoundException ought to result in an error with http status code 404, but protorpc detects it as a subclass of protorpc.remote.ApplicationError and sends 400 instead.
@inklesspen
Copy link
Contributor Author

https://github.com/google/protorpc/blob/95849c9a3e414b9ba2d3da91fd850156348fe558/protorpc/wsgi/service.py#L184

@dgaedcke
Copy link

is anyone going to fix this? makes it quite hard to debug problems before it even hits our code

@inklesspen
Copy link
Contributor Author

ProtoRPC is not actively maintained, and was never intended to be used for this use case anyway, but I will fix it if I can figure out a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inklesspen @dgaedcke