fix: HTTP headers for extensions with false values #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudEvent objects may include extensions that have a defined key and a `false` value. This change ensures that HTTP messages for CloudEvents containing these extension values include the appropriate headers. Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
grant
approved these changes
Jun 14, 2022
|
Closing and reopening to re-trigger CI with updated package.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudEvent objects may include extensions that have a defined key and a
falsevalue. This change ensures that HTTP messages for CloudEventscontaining these extension values include the appropriate headers.
Fixes: #492
Signed-off-by: Lance Ball lball@redhat.com