Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare: update rate limit exceeded error message #1043

Conversation

jacobbednarz
Copy link
Member

Updates the messaging when the rate limit retry policy has been
exhausted to convey the actual failure instead of the generic could not read response body failure.

Closes #1041
Closes cloudflare/terraform-provider-cloudflare#1834

Updates the messaging when the rate limit retry policy has been
exhausted to convey the actual failure instead of the generic `could not
read response body` failure.
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1043 (649e56d) into master (6c5ea4a) will increase coverage by 0.67%.
The diff coverage is 62.85%.

@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
+ Coverage   49.06%   49.73%   +0.67%     
==========================================
  Files         108      115       +7     
  Lines       10428    10977     +549     
==========================================
+ Hits         5116     5459     +343     
- Misses       4200     4351     +151     
- Partials     1112     1167      +55     
Impacted Files Coverage Δ
access_application.go 76.52% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
workers_account_settings.go 35.71% <35.71%> (ø)
rulesets.go 35.09% <47.36%> (+7.43%) ⬆️
workers_tail.go 52.00% <52.00%> (ø)
workers_subdomain.go 57.14% <57.14%> (ø)
email_routing_settings.go 60.00% <60.00%> (ø)
email_routing_rules.go 65.64% <65.64%> (ø)
lockdown.go 57.69% <66.00%> (+6.94%) ⬆️
email_routing_destination.go 66.25% <66.25%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jacobbednarz jacobbednarz merged commit 63b6ab8 into cloudflare:master Aug 15, 2022
@jacobbednarz jacobbednarz deleted the better-rate-limit-retry-exceeded-error branch August 15, 2022 23:13
@github-actions github-actions bot added this to the v0.47.0 milestone Aug 15, 2022
github-actions bot pushed a commit that referenced this pull request Aug 15, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v0.47.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ratelimit code seems to fail Error: error listing zones: could not read response body: %!w(<nil>)
2 participants