-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for cache reserve #1278
Merged
jacobbednarz
merged 4 commits into
cloudflare:master
from
jfchevrette:zone-cache-reserve
May 15, 2023
Merged
add support for cache reserve #1278
jacobbednarz
merged 4 commits into
cloudflare:master
from
jfchevrette:zone-cache-reserve
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfchevrette
force-pushed
the
zone-cache-reserve
branch
from
May 8, 2023 23:40
68ba2a3
to
d7fc5d4
Compare
changelog detected ✅ |
jfchevrette
force-pushed
the
zone-cache-reserve
branch
2 times, most recently
from
May 9, 2023 00:41
a5193d1
to
ffd506d
Compare
kwilczynski
reviewed
May 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
==========================================
- Coverage 49.07% 49.05% -0.02%
==========================================
Files 133 134 +1
Lines 13032 13064 +32
==========================================
+ Hits 6395 6409 +14
- Misses 5143 5155 +12
- Partials 1494 1500 +6
|
jfchevrette
force-pushed
the
zone-cache-reserve
branch
from
May 10, 2023 12:40
ffd506d
to
f047e55
Compare
jacobbednarz
force-pushed
the
zone-cache-reserve
branch
from
May 15, 2023 00:26
509931d
to
141e388
Compare
jacobbednarz
force-pushed
the
zone-cache-reserve
branch
from
May 15, 2023 00:29
141e388
to
5e5c2b2
Compare
This functionality has been released in v0.68.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for retrieving and updating the
Cache Reserve
setting on a zoneThis is a rather naive implementation which follows the same pattern as the argo.go methods
Closes #1277
Has your change been tested?
Unit tests included
I also tested locally on a real account and I was able to retrieve and set the cache_reserve setting
Types of changes
What sort of change does your code introduce/modify?
Checklist: