revamp DNS firewall methods, remove virtual DNS #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an alias for the newer DNS firewall. Since we are revampign the DNS firewall file, we should remove this now to avoid introducing breaking changes to these older methods.
This shouldn't be used anywhere however, we can add support here until it's fully quashed as a concept in the services.
Updates the method conventions[1] to match the experimental client[2] bringing in more modern support and usage. [1]: https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md [2]: https://github.com/cloudflare/cloudflare-go/blob/master/docs/experimental.md
jacobbednarz
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
==========================================
+ Coverage 48.95% 49.05% +0.10%
==========================================
Files 135 134 -1
Lines 13180 13120 -60
==========================================
- Hits 6452 6436 -16
+ Misses 5212 5168 -44
Partials 1516 1516
|
|
changelog detected ✅ |
|
This functionality has been released in v0.70.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an alias for the newer DNS firewall. Since we are revamping the
DNS firewall file, we should remove this now to avoid introducing
breaking changes to these older methods.
This PR is also removing the last dependency on
api.UserBaseURLwhichwe can pull out following this being merged 🎉
Best reviewed commit by commit ignoring 453ca7f given it is an internal
change.