Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GET for DCV Delegation UUID endpoint #1384

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

troymjones
Copy link
Contributor

@troymjones troymjones commented Aug 30, 2023

Description

https://api.cloudflare.com/client/v4/zones/<zone_id>/dcv_delegation/uuid is not currently supported by the Go SDK.
closes #1383

Has your change been tested?

Unit tests added in changes

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

changelog detected ✅

@vasilzhigilei
Copy link
Contributor

vasilzhigilei commented Sep 6, 2023

Code looks good from SSL team side
Edit: we'll add API docs to unblock this

@vasilzhigilei
Copy link
Contributor

API docs are now available: https://developers.cloudflare.com/api/operations/dcv-delegation-uuid-get

dcv_delegation.go Outdated Show resolved Hide resolved
dcv_delegation.go Outdated Show resolved Hide resolved
dcv_delegation.go Outdated Show resolved Hide resolved
dcv_delegation.go Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1384 (93050ce) into master (b9ac804) will increase coverage by 0.08%.
Report is 265 commits behind head on master.
The diff coverage is 50.39%.

@@            Coverage Diff             @@
##           master    #1384      +/-   ##
==========================================
+ Coverage   48.33%   48.42%   +0.08%     
==========================================
  Files         133      140       +7     
  Lines       13023    13822     +799     
==========================================
+ Hits         6295     6693     +398     
- Misses       5201     5470     +269     
- Partials     1527     1659     +132     
Files Changed Coverage Δ
access_audit_log.go 79.31% <ø> (ø)
access_bookmark.go 72.44% <ø> (ø)
access_keys.go 71.42% <ø> (ø)
access_organization.go 53.84% <ø> (ø)
access_service_tokens.go 51.85% <ø> (ø)
account_members.go 65.54% <ø> (ø)
account_roles.go 53.84% <ø> (ø)
accounts.go 50.81% <ø> (ø)
addressing_address_map.go 39.04% <ø> (ø)
addressing_ip_prefix.go 45.45% <ø> (ø)
... and 122 more

... and 1 file with indirect coverage changes

@jacobbednarz jacobbednarz merged commit 59b0c12 into cloudflare:master Sep 12, 2023
11 checks passed
@github-actions github-actions bot added this to the v0.77.0 milestone Sep 12, 2023
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.77.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GET for /dcv_delegation/uuid
4 participants