Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access_users: Add ZeroTrust Users & Seats functions. #1427

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

gavinelder
Copy link
Contributor

@gavinelder gavinelder commented Oct 26, 2023

Description

Closes #1425

The following adds the Cloudflare Zerotrust / Access endpoints for user & seat management.

The following is a rough draft with comments for feedback.

Has your change been tested?

Basic API calls locally against relevant endpoints to ensure a proper response is given.

Types of changes

What sort of change does your code introduce/modify?

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

changelog detected ✅

Copy link
Contributor Author

@gavinelder gavinelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add relevant comments .

Right now as far as testing goes, outside of basic response unmarshelling I am unsure what you would like to see.

access_seats.go Outdated Show resolved Hide resolved
access_seats.go Outdated Show resolved Hide resolved
access_seats_test.go Outdated Show resolved Hide resolved
access_user.go Outdated Show resolved Hide resolved
access_user.go Outdated Show resolved Hide resolved
access_seats.go Outdated Show resolved Hide resolved
access_seats.go Outdated Show resolved Hide resolved
access_seats.go Outdated Show resolved Hide resolved
@gavinelder gavinelder changed the title Add Access Seats Scaffolding access_users: Add ZeroTrust Users & Seats functions. Oct 27, 2023
@gavinelder
Copy link
Contributor Author

@jacobbednarz thanks for the review, this should hopefully be in a better state now.

@gavinelder gavinelder marked this pull request as ready for review October 27, 2023 17:18
access_seats.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 60a9425 into cloudflare:master Oct 30, 2023
10 of 11 checks passed
@jacobbednarz
Copy link
Member

thanks for this one @gavinelder 🏆

@github-actions github-actions bot added this to the v0.81.0 milestone Oct 30, 2023
Copy link
Contributor

This functionality has been released in v0.81.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zerotrust / Access User endpoints.
2 participants