Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers cannot be returned from a DO WebSocket response #151

Closed
jed opened this issue Jan 14, 2022 · 3 comments
Closed

Headers cannot be returned from a DO WebSocket response #151

jed opened this issue Jan 14, 2022 · 3 comments
Labels
behaviour mismatch Different behaviour to Workers runtime

Comments

@jed
Copy link

jed commented Jan 14, 2022

Headers specified in the WebSocket response returned from the fetch function of a Durable Object appear to be ignored in miniflare but not in production. Here's a repro.

In this case, the x-it-worked header is returned when deployed to Cloudflare, but not in miniflare.
@jed
Copy link
Author

jed commented Jan 14, 2022

Not sure, but perhaps this is the reason?

@mrbbot mrbbot closed this as completed in 92d98c9 Jan 14, 2022
@mrbbot mrbbot added behaviour mismatch Different behaviour to Workers runtime v2.1.0 labels Jan 14, 2022
@mrbbot
Copy link
Contributor

mrbbot commented Jan 14, 2022

Hey! 👋 I've just released version 2.1.0 including a fix for this. You can find the full changelog here. That link you provided was actually a different bug 😅, which is also fixed now.

@jed
Copy link
Author

jed commented Jan 14, 2022

Awesome, thanks @mrbbot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
behaviour mismatch Different behaviour to Workers runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jed @mrbbot