Websockets sometimes try to close with 1005

[hansottowirtz]

I'm trying to use Cloudflare Tunnel to connect to a Postgres database, which I believe uses WebSockets under the hood. Sometimes, WebSockets try to close with code 1005, resulting in an error:

First argument must be a valid error code number

miniflare/packages/web-sockets/src/couple.ts

Lines 46 to 48 in 20b7159

	pair.addEventListener("close", (e) => {
	if (ws.readyState < StandardWebSocket.CLOSING) ws.close(e.code, e.reason);
	});

Replacing this with:

ws.close(e.code === 1005 ? 1000 : e.code, e.reason);

seems to solve the problem, but I'm not sure whether there's an underlying issue in WebSocketPair or not.

[mrbbot]

Hey! 👋 Thanks for raising this. Will be fixed in the next release. 🙂