Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content-encoding stripped from response? #312

Closed
vlovich opened this issue Jul 15, 2022 · 1 comment
Closed

content-encoding stripped from response? #312

vlovich opened this issue Jul 15, 2022 · 1 comment
Milestone
2.7.0

Comments

@vlovich
Copy link
Contributor

vlovich commented Jul 15, 2022

I set a content-encoding of 'custom' for a response Miniflare is generating and for some reason it seems to be stripped off when the caller receives it. When I run it in deployed Cloudflare Workers that is not the case & the content-encoding is returned successfully.

Additionally, I noticed that the vary header is not set in the response when accept-encoding is sent (edge returns vary: accept-encoding).
@mrbbot mrbbot closed this as completed in ae2349c Aug 11, 2022
@mrbbot mrbbot added this to the 2.7.0 milestone Aug 11, 2022
@mrbbot
Copy link
Contributor

mrbbot commented Aug 11, 2022

Hey! 👋 Looks like Content-Encoding was being deleted when it wasn't recognised. Fixed now. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@vlovich @mrbbot