Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Ensure ALL supported types are exposed to DevBindingsOptions #634

Closed
1 task
admah opened this issue Jan 12, 2024 · 2 comments · Fixed by #648
Closed
1 task

[🐛 Bug]: Ensure ALL supported types are exposed to DevBindingsOptions #634

admah opened this issue Jan 12, 2024 · 2 comments · Fixed by #648
Assignees
Labels
blocked by external This can't be currently solved because of external factors (Vercel/Next, Pages, etc...) bug Something isn't working

Comments

@admah
Copy link

admah commented Jan 12, 2024

next-on-pages environment related information

No response

Description

DevBindingsOptions seems to be missing types around queues. I'm not sure if there are others (AI?).

Is there a reason all of Miniflare's supported binding types aren't listed?

Reproduction

No response

Pages Deployment Method

None

Pages Deployment ID

No response

Additional Information

No response

Would you like to help?

  • Would you like to help fixing this bug?
@admah admah added the bug Something isn't working label Jan 12, 2024
@dario-piotrowicz
Copy link
Member

dario-piotrowicz commented Jan 14, 2024

@admah it's not just the types but the missing bindings are actually not currently supported by next-dev.

This is something was aware of, I did not add them for various reasons, mainly because their addition here (although not extremely hard) would not be trivial, so I thought that it would make more sense for now to include the current common and simple to support ones and to then add support for all of bindings when we use getBindingsProxy instead (since I am working on both these utilities I think I should just focus my efforts on getBindingsProxy instead of trying to implement the same logic twice, only to then deprecate the next-dev version).

For some context, I did implement the AI binding in #597, it worked fine, but again, it sounded safer/cleaner not to go with such implementation but wait for getBindingsProxy instead.

Regarding queues, they are not supported in wrangler pages dev that's why they haven't been added to next-dev (see #526). They being supported by next-dev but not wrangler pages dev doesn't really seem right to me (since as mentioned in the suggested workflow I think that ideally developers should be using both next-dev and wrangler pages dev).

So my suggestion here would be to wait for #623 to be resolved, once it is we can then revisit this issue (which should hopefully be already solved).

What do you think? does that sound ok to you? or would you prefer a different approach?
(note: I think that releasing getBidingsProxy should not take more then a couple of weeks maximum)

@admah
Copy link
Author

admah commented Jan 16, 2024

Thanks for the additional context here @dario-piotrowicz! I think continuing to focus on getBindingsProxy is the way to go.

Also agreed that queues support should be in both so we can revisit that later 👍

@dario-piotrowicz dario-piotrowicz added the blocked by external This can't be currently solved because of external factors (Vercel/Next, Pages, etc...) label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by external This can't be currently solved because of external factors (Vercel/Next, Pages, etc...) bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants