Trait methods should not take patterns like mut IDENT as arguments

[l2dy]

According to E0642 and rust-lang/rust#35203, trait methods should not take patterns as arguments, including patterns like mut IDENT. But Pingora is using it in several places.

pingora/pingora-core/src/services/background.rs

Line 34 in b0bd0fb

async fn start(&self, mut shutdown: ShutdownWatch);

pingora/pingora-core/src/apps/mod.rs

Line 48 in b0bd0fb

mut session: Stream,

pingora/pingora-core/src/apps/mod.rs

Line 74 in b0bd0fb

mut session: ServerSession,

pingora/pingora-core/src/services/mod.rs

Line 42 in b0bd0fb

async fn start_service(&mut self, fds: Option<ListenFds>, mut shutdown: ShutdownWatch);

Without function body, mut seems ineffective. Is there a good reason to keep them?

Pingora info

Please include the following information about your environment:

Pingora version: commit b0bd0fb
Rust version: cargo 1.80.1 (376290515 2024-07-16)
Operating system version: N/A