From a42344198d14b5bfcc0dd163a88404da7b435337 Mon Sep 17 00:00:00 2001 From: Peter Bacon Darwin Date: Sun, 6 Oct 2024 15:51:13 +0100 Subject: [PATCH] fix: ensure that `alias` config gets passed through to the bundler when using new `--x-dev-env` Fixes #6898 --- .changeset/grumpy-apples-juggle.md | 7 +++++++ .../__tests__/api/startDevWorker/ConfigController.test.ts | 8 +++++++- .../wrangler/src/api/startDevWorker/ConfigController.ts | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 .changeset/grumpy-apples-juggle.md diff --git a/.changeset/grumpy-apples-juggle.md b/.changeset/grumpy-apples-juggle.md new file mode 100644 index 000000000000..7d374b96ddd8 --- /dev/null +++ b/.changeset/grumpy-apples-juggle.md @@ -0,0 +1,7 @@ +--- +"wrangler": patch +--- + +fix: ensure that `alias` config gets passed through to the bundler when using new `--x-dev-env` + +Fixes #6898 diff --git a/packages/wrangler/src/__tests__/api/startDevWorker/ConfigController.test.ts b/packages/wrangler/src/__tests__/api/startDevWorker/ConfigController.test.ts index 77617274e7a3..ae4abd05adc7 100644 --- a/packages/wrangler/src/__tests__/api/startDevWorker/ConfigController.test.ts +++ b/packages/wrangler/src/__tests__/api/startDevWorker/ConfigController.test.ts @@ -123,14 +123,20 @@ describe("ConfigController", () => { dev: { origin: { hostname: "myexample.com" }, }, + build: { + alias: { foo: "bar" }, + }, }); - // expect `dev` field to be overwritten and all other config to remain intact + // expect `dev` and `build.alias` fields to be overwritten and all other config to remain intact await expect(event3).resolves.toMatchObject({ type: "configUpdate", config: { entrypoint: path.join(process.cwd(), "src/index.ts"), directory: process.cwd(), build: { + alias: { + foo: "bar", + }, additionalModules: [], define: {}, format: "modules", diff --git a/packages/wrangler/src/api/startDevWorker/ConfigController.ts b/packages/wrangler/src/api/startDevWorker/ConfigController.ts index 49ea954ee5b9..3278c3cfe4d8 100644 --- a/packages/wrangler/src/api/startDevWorker/ConfigController.ts +++ b/packages/wrangler/src/api/startDevWorker/ConfigController.ts @@ -257,6 +257,7 @@ async function resolveConfig( triggers: await resolveTriggers(config, input), env: input.env, build: { + alias: input.build?.alias ?? config.alias, additionalModules: input.build?.additionalModules ?? [], processEntrypoint: Boolean(input.build?.processEntrypoint), bundle: input.build?.bundle ?? !config.no_bundle,