Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: better-sqlite3@7.6.2 not working on macOS 13.0.1, needs @8.0.0 #2274

Closed
Niek opened this issue Nov 23, 2022 · 4 comments
Closed

🐛 BUG: better-sqlite3@7.6.2 not working on macOS 13.0.1, needs @8.0.0 #2274

Niek opened this issue Nov 23, 2022 · 4 comments
Assignees
@geelen @rozenmd
Labels
bug Something that isn't working d1 Relating to D1 miniflare Relating to Miniflare

Comments

@Niek
Copy link

Niek commented Nov 23, 2022

What version of Wrangler are you using?

2.1.13

What operating system are you using?

macOS

Describe the Bug

Running this command fails on macOS Venture 13.0.1:

wrangler d1 execute test --local --command='select *'

It was fixed by upgrading better-sqlite3 to version 8.0.0 in my package.json.
@Niek Niek added the bug Something that isn't working label Nov 23, 2022
@workers-devprod workers-devprod moved this to Untriaged in workers-sdk Nov 23, 2022
@penalosa penalosa added the d1 Relating to D1 label Nov 23, 2022
@penalosa
Copy link
Contributor

penalosa commented Nov 23, 2022 •
edited
Loading

Thanks for reporting this! @rozenmd @geelen Could you investigate to see if upgrading would break any local d1 stuff?

@rozenmd
Copy link
Contributor

rozenmd commented Nov 24, 2022 •
edited
Loading

The only breaking change was that they dropped support for Node 10 and 12, which we don't support @penalosa - how do we go about bumping this? Does miniflare need to bump it first?

@lrapoport-cf lrapoport-cf moved this from Untriaged to Backlog in workers-sdk Jan 4, 2023
@mrbbot
Copy link
Contributor

mrbbot commented Jan 4, 2023

Hey! We bumped better-sqlite3 to 8.0.1 in Miniflare here cloudflare/miniflare@7c7d9de, although this change hasn't been released yet. Will try update this issue when it is. 👍

@mrbbot mrbbot mentioned this issue Jan 9, 2023
Closed
@rozenmd rozenmd added the miniflare Relating to Miniflare label Jan 23, 2023
@mrbbot mrbbot mentioned this issue Feb 14, 2023
Merged
6 tasks
@mrbbot
Copy link
Contributor

mrbbot commented Feb 15, 2023

Hey! 👋 This should be fixed by #2717, which will be released very soon. 👍

@mrbbot mrbbot closed this as completed Feb 15, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in workers-sdk Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geelen geelen

@rozenmd rozenmd

Labels
bug Something that isn't working d1 Relating to D1 miniflare Relating to Miniflare
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@geelen @Niek @rozenmd @mrbbot @penalosa